feat: display hidden iconset#384
Conversation
✅ Deploy Preview for icones ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR enables the display of deprecated/unavailable icon sets that were previously filtered out entirely. Instead of excluding these "hidden" iconsets, they are now categorized under "Deprecated / Unavailable" (which is excluded by default via user settings) and displayed with visual indicators throughout the UI.
- Icon sets with
hidden: trueare now assigned to the "Deprecated / Unavailable" category instead of being filtered out at the data preparation stage - Visual indicators (orange information icon, dashed borders, line-through styling, reduced opacity) are added across multiple components to clearly mark deprecated icon sets
- The "Deprecated / Unavailable" category is added to the default excluded categories list, maintaining the current user experience while allowing manual discovery
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/prepare.ts | Removes the filter that excluded hidden collections; instead assigns them to "Deprecated / Unavailable" category |
| src/data/index.ts | Adds hidden property to CollectionInfo interface with documentation |
| src/store/localstorage.ts | Adds "Deprecated / Unavailable" to default excluded categories |
| src/pages/index.vue | Adds sticky category headers, filters for available categories, and improves platform detection for keyboard shortcuts |
| src/components/IconSet.vue | Displays deprecation indicator icon with tooltip in the icon set header |
| src/components/Drawer.vue | Shows deprecation indicator icon next to collection names in the drawer |
| src/components/CollectionEntry.vue | Adds comprehensive visual styling for hidden collections including dashed borders, line-through text, reduced opacity, and deprecation indicator icon |
| unocss.config.ts | Increases border base opacity from 15 to 25 for better visibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * The icon set was deprecated and is no longer available | ||
| */ | ||
| hidden?: boolean |
There was a problem hiding this comment.
|
What's the reason we still need to display them? |
I was using an icon collection, but I don't know why it was marked |
|
A bit of context. Icon sets are marked as hidden when:
Fluent Emoji is a special case and it was forced by GitHub. That icon set has icons with massive amounts of gradients and shadows, so each icon is about 30kb. It is a big icon set, there are many icons. That resulted in JSON file reaching 100mb mark. GitHub does not allow files larger than 100kb, preventing commit from being published. On Iconify website hidden icon sets are handled this way: hidden by default, shown when user types prefix or name in filter that matches a hidden set. I suggest adding additional check to make sure duplicates aren't shown. |
Description
Manually manage
hiddenicon sets instead of excluding them outright, even if they have been marked as deprecated or unavailable.For deprecated iconset ui
Linked Issues
Related to b74141e
Additional context